Delete duplicated check for jar_path #17174

ItsLastDay · 2022-12-20T14:00:09Z

The same if statement is already present on line 230.

Description: refactoring: delete duplicated code.

Link to tracking Issue: none

Testing: no tests added; I'm hoping that CI will catch any errors

Documentation: none

The same `if` statement is already present on line 230.

runforesight · 2022-12-20T14:02:20Z

Foresight Summary

Major Impacts

build-and-test-windows duration(3 seconds) has decreased 43 minutes 45 seconds compared to main branch avg(43 minutes 48 seconds).

View More Details

✅ check-links workflow has finished in 43 seconds (2 minutes 51 seconds less than `main` branch avg.) and finished at 20th Dec, 2022.

Job	Failed Steps	Tests
changed files	- 🔗	N/A	See Details
check-links	- 🔗	N/A	See Details

✅ tracegen workflow has finished in 1 minute 3 seconds (2 minutes 51 seconds less than `main` branch avg.) and finished at 20th Dec, 2022.

Job	Failed Steps	Tests
build-dev	- 🔗	N/A	See Details
publish-latest	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details

✅ prometheus-compliance-tests workflow has finished in 3 minutes 24 seconds (6 minutes 34 seconds less than `main` branch avg.) and finished at 20th Dec, 2022.

Job	Failed Steps	Tests
prometheus-compliance-tests	- 🔗	✅ 21 ❌ 0 ⏭ 0 🔗	See Details

✅ build-and-test workflow has finished in 37 minutes 46 seconds (22 minutes 38 seconds less than `main` branch avg.) and finished at 20th Dec, 2022.

Job	Failed Steps	Tests
unittest-matrix (1.18, internal)	- 🔗	✅ 592 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, extension)	- 🔗	✅ 528 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, processor)	- 🔗	✅ 1474 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, processor)	- 🔗	✅ 1474 ❌ 0 ⏭ 0 🔗	See Details
correctness-traces	- 🔗	✅ 17 ❌ 0 ⏭ 0 🔗	See Details
correctness-metrics	- 🔗	✅ 2 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, receiver-0)	- 🔗	✅ 2539 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, receiver-0)	- 🔗	✅ 2539 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, extension)	- 🔗	✅ 528 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, internal)	- 🔗	✅ 592 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, exporter)	- 🔗	✅ 2456 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, other)	- 🔗	✅ 4394 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, receiver-1)	- 🔗	✅ 1854 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, other)	- 🔗	✅ 4394 ❌ 0 ⏭ 0 🔗	See Details
integration-tests	- 🔗	✅ 55 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, receiver-1)	- 🔗	✅ 1854 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, exporter)	- 🔗	✅ 2456 ❌ 0 ⏭ 0 🔗	See Details
setup-environment	- 🔗	N/A	See Details
check-collector-module-version	- 🔗	N/A	See Details
checks	- 🔗	N/A	See Details
build-examples	- 🔗	N/A	See Details
check-codeowners	- 🔗	N/A	See Details
lint-matrix (receiver-0)	- 🔗	N/A	See Details
lint-matrix (processor)	- 🔗	N/A	See Details
lint-matrix (exporter)	- 🔗	N/A	See Details
lint-matrix (extension)	- 🔗	N/A	See Details
lint-matrix (internal)	- 🔗	N/A	See Details
lint-matrix (receiver-1)	- 🔗	N/A	See Details
lint-matrix (other)	- 🔗	N/A	See Details
lint	- 🔗	N/A	See Details
unittest (1.19)	- 🔗	N/A	See Details
unittest (1.18)	- 🔗	N/A	See Details
cross-compile (darwin, amd64)	- 🔗	N/A	See Details
cross-compile (darwin, arm64)	- 🔗	N/A	See Details
cross-compile (linux, 386)	- 🔗	N/A	See Details
cross-compile (linux, amd64)	- 🔗	N/A	See Details
cross-compile (linux, arm)	- 🔗	N/A	See Details
cross-compile (linux, arm64)	- 🔗	N/A	See Details
cross-compile (linux, ppc64le)	- 🔗	N/A	See Details
cross-compile (windows, 386)	- 🔗	N/A	See Details
cross-compile (windows, amd64)	- 🔗	N/A	See Details
build-package (deb)	- 🔗	N/A	See Details
build-package (rpm)	- 🔗	N/A	See Details
windows-msi	- 🔗	N/A	See Details
publish-check	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details
publish-dev	- 🔗	N/A	See Details

✅ load-tests workflow has finished in 8 minutes 11 seconds (9 minutes 21 seconds less than `main` branch avg.) and finished at 20th Dec, 2022.

Job	Failed Steps	Tests
loadtest (TestTraceAttributesProcessor)	- 🔗	✅ 3 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceNoBackend10kSPS\|TestTrace1kSPSWithAttrs)	- 🔗	✅ 8 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestBallastMemory\|TestLog10kDPS)	- 🔗	✅ 19 ❌ 0 ⏭ 0 🔗	See Details
setup-environment	- 🔗	N/A	See Details
loadtest (TestIdleMode)	- 🔗	✅ 1 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetric10kDPS\|TestMetricsFromFile)	- 🔗	✅ 6 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetricResourceProcessor\|TestTrace10kSPS)	- 🔗	✅ 12 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceBallast1kSPSWithAttrs\|TestTraceBallast1kSPSAddAttrs)	- 🔗	✅ 10 ❌ 0 ⏭ 0 🔗	See Details

⭕ changelog workflow has finished in 2 seconds (9 minutes less than `main` branch avg.) and finished at 20th Dec, 2022.

Job	Failed Steps	Tests
changelog	- 🔗	N/A	See Details

⭕ build-and-test-windows workflow has finished in 3 seconds (43 minutes 45 seconds less than `main` branch avg.) and finished at 20th Dec, 2022.

Job	Failed Steps	Tests
windows-unittest-matrix	- 🔗	N/A	See Details
windows-unittest	- 🔗	N/A	See Details

🔎 See details on Foresight

^{*You can configure Foresight comments in your organization settings page.}

Delete duplicated check for jar_path

6c4a6ae

The same `if` statement is already present on line 230.

ItsLastDay requested review from a team and Aneurysm9 December 20, 2022 14:00

github-actions bot assigned Aneurysm9 Dec 20, 2022

github-actions bot added the receiver/jmx JMX Receiver label Dec 20, 2022

github-actions bot requested a review from rmfitzpatrick December 20, 2022 14:00

codeboten approved these changes Dec 20, 2022

View reviewed changes

codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 20, 2022

codeboten merged commit ce23ea4 into open-telemetry:main Dec 20, 2022

plantfansam mentioned this pull request Jul 21, 2023

disregard #24427

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete duplicated check for jar_path #17174

Delete duplicated check for jar_path #17174

ItsLastDay commented Dec 20, 2022

runforesight bot commented Dec 20, 2022 •

edited

Loading

`build-and-test-windows` duration(3 seconds) has decreased 43 minutes 45 seconds compared to main branch avg(43 minutes 48 seconds).

✅ check-links workflow has finished in 43 seconds (2 minutes 51 seconds less than `main` branch avg.) and finished at 20th Dec, 2022.

✅ tracegen workflow has finished in 1 minute 3 seconds (2 minutes 51 seconds less than `main` branch avg.) and finished at 20th Dec, 2022.

✅ prometheus-compliance-tests workflow has finished in 3 minutes 24 seconds (6 minutes 34 seconds less than `main` branch avg.) and finished at 20th Dec, 2022.

✅ build-and-test workflow has finished in 37 minutes 46 seconds (22 minutes 38 seconds less than `main` branch avg.) and finished at 20th Dec, 2022.

✅ load-tests workflow has finished in 8 minutes 11 seconds (9 minutes 21 seconds less than `main` branch avg.) and finished at 20th Dec, 2022.

⭕ changelog workflow has finished in 2 seconds (9 minutes less than `main` branch avg.) and finished at 20th Dec, 2022.

⭕ build-and-test-windows workflow has finished in 3 seconds (43 minutes 45 seconds less than `main` branch avg.) and finished at 20th Dec, 2022.

Delete duplicated check for jar_path #17174

Delete duplicated check for jar_path #17174

Conversation

ItsLastDay commented Dec 20, 2022

runforesight bot commented Dec 20, 2022 • edited Loading

Foresight Summary

build-and-test-windows duration(3 seconds) has decreased 43 minutes 45 seconds compared to main branch avg(43 minutes 48 seconds).

✅ check-links workflow has finished in 43 seconds (2 minutes 51 seconds less than main branch avg.) and finished at 20th Dec, 2022.

✅ tracegen workflow has finished in 1 minute 3 seconds (2 minutes 51 seconds less than main branch avg.) and finished at 20th Dec, 2022.

✅ prometheus-compliance-tests workflow has finished in 3 minutes 24 seconds (6 minutes 34 seconds less than main branch avg.) and finished at 20th Dec, 2022.

✅ build-and-test workflow has finished in 37 minutes 46 seconds (22 minutes 38 seconds less than main branch avg.) and finished at 20th Dec, 2022.

✅ load-tests workflow has finished in 8 minutes 11 seconds (9 minutes 21 seconds less than main branch avg.) and finished at 20th Dec, 2022.

⭕ changelog workflow has finished in 2 seconds (9 minutes less than main branch avg.) and finished at 20th Dec, 2022.

⭕ build-and-test-windows workflow has finished in 3 seconds (43 minutes 45 seconds less than main branch avg.) and finished at 20th Dec, 2022.

runforesight bot commented Dec 20, 2022 •

edited

Loading

`build-and-test-windows` duration(3 seconds) has decreased 43 minutes 45 seconds compared to main branch avg(43 minutes 48 seconds).

✅ check-links workflow has finished in 43 seconds (2 minutes 51 seconds less than `main` branch avg.) and finished at 20th Dec, 2022.

✅ tracegen workflow has finished in 1 minute 3 seconds (2 minutes 51 seconds less than `main` branch avg.) and finished at 20th Dec, 2022.

✅ prometheus-compliance-tests workflow has finished in 3 minutes 24 seconds (6 minutes 34 seconds less than `main` branch avg.) and finished at 20th Dec, 2022.

✅ build-and-test workflow has finished in 37 minutes 46 seconds (22 minutes 38 seconds less than `main` branch avg.) and finished at 20th Dec, 2022.

✅ load-tests workflow has finished in 8 minutes 11 seconds (9 minutes 21 seconds less than `main` branch avg.) and finished at 20th Dec, 2022.

⭕ changelog workflow has finished in 2 seconds (9 minutes less than `main` branch avg.) and finished at 20th Dec, 2022.

⭕ build-and-test-windows workflow has finished in 3 seconds (43 minutes 45 seconds less than `main` branch avg.) and finished at 20th Dec, 2022.